> On nov. 22, 2015, 9:41 après-midi, Ralf Engels wrote: > > Could you also state a reason for the change? > > Is that just to get rid of the usage of a KDE dialog where a "plain" Qt > > dialog is sufficient?
The equalizer was not shown: the dialog was really strange. I tried a to play around but did not achieve anything. At the end I tried this and it worked. It seems also that a plain QDialog is enough, so why should we use something more complex? - Olivier ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126128/#review88699 ----------------------------------------------------------- On nov. 21, 2015, 4:02 après-midi, Olivier Churlaud wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126128/ > ----------------------------------------------------------- > > (Updated nov. 21, 2015, 4:02 après-midi) > > > Review request for Amarok and Ralf Engels. > > > Repository: amarok > > > Description > ------- > > EqualizerDialog is now a QDialog > > > Diffs > ----- > > src/dialogs/EqualizerDialog.h 53654b6 > src/dialogs/EqualizerDialog.cpp 936fd20 > src/dialogs/EqualizerDialog.ui 7fc5a7d > > Diff: https://git.reviewboard.kde.org/r/126128/diff/ > > > Testing > ------- > > Compiles, run, behave correctly. > > > Thanks, > > Olivier Churlaud > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
