> On Nov. 3, 2015, 10:39 p.m., Stefan Derkits wrote: > > Thanks for the review request. The problem is Playdar is dead (last commit > > & website entry were over 5 years ago) and was sort of succeeded by > > Tomahawk. So I don't know how much future the Playdar collection and with > > it this pull-request has.
Ah, didn't now. Maybe we can apply the changes related to CMakeLists and README then? (to drop qjson) - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125937/#review87964 ----------------------------------------------------------- On Nov. 3, 2015, 10:39 p.m., Andrea Scarpino wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125937/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2015, 10:39 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > We don't need anymore qjson. Use QJsonDocument instead. > > > Diffs > ----- > > CMakeLists.txt 8cf9af3 > README 32e4824 > cmake/modules/FindQJSON.cmake 5fafca5 > src/core-impl/collections/CMakeLists.txt 757d8d0 > src/core-impl/collections/playdarcollection/CMakeLists.txt 06def29 > src/core-impl/collections/playdarcollection/support/Controller.cpp d584ac1 > src/core-impl/collections/playdarcollection/support/Query.cpp 5a28004 > > Diff: https://git.reviewboard.kde.org/r/125937/diff/ > > > Testing > ------- > > Build. > > > Thanks, > > Andrea Scarpino > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
