----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125519/#review86342 -----------------------------------------------------------
Ship it! Ship It! - Olivier Churlaud On oct. 4, 2015, 7:44 après-midi, Aditya Dev Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125519/ > ----------------------------------------------------------- > > (Updated oct. 4, 2015, 7:44 après-midi) > > > Review request for Amarok, Stefan Derkits and Olivier Churlaud. > > > Repository: amarok > > > Description > ------- > > Replaced the KApplication with QApplication and hence used isSavingSession() > > > Diffs > ----- > > src/MainWindow.cpp ce1710f > src/aboutdialog/ExtendedAboutDialog.cpp 381905c > src/amarokurls/BookmarkManager.cpp 7c42ecf > src/core-impl/collections/db/sql/SqlCollection.cpp ca20601 > src/core/support/Amarok.h 8d80de6 > src/core/support/Amarok.cpp 411b89c > src/core/support/Debug.cpp 07af24a > src/covermanager/CoverFetchingActions.cpp f66197e > src/covermanager/CoverManager.cpp a408436 > src/covermanager/CoverViewDialog.cpp 626ccb9 > src/dbus/mpris1/PlayerHandler.cpp acaa119 > src/dbus/mpris1/RootHandler.cpp 6d1e3b3 > src/dbus/mpris1/TrackListHandler.cpp eb0b5ca > src/dbus/mpris2/MediaPlayer2.cpp c928da0 > src/dialogs/DiagnosticDialog.cpp 61dbde4 > src/dialogs/deviceconfiguredialog.cpp 70a93ce > src/dialogs/transferdialog.cpp 45b6ed0 > src/playlist/view/listview/PrettyListView.cpp aabf0b4 > src/scripting/scriptengine/AmarokLyricsScript.cpp ccc7721 > src/services/mp3tunes/Mp3tunesHarmonyHandler.cpp bfebfe5 > src/toolbar/SlimToolbar.cpp 68f6cfc > src/widgets/Osd.cpp de33567 > src/widgets/PixmapViewer.cpp 387f95d > src/widgets/SliderWidget.cpp bf21922 > src/widgets/Token.cpp 05a0b78 > src/widgets/TokenPool.cpp a13d97b > > Diff: https://git.reviewboard.kde.org/r/125519/diff/ > > > Testing > ------- > > Builds 100 % > Fixed the error and changed all <KApplication> stuff to <QApplication> . > Commented qApp->setTopWidget() until further information. > > > Thanks, > > Aditya Dev Sharma > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
