----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124773/#review85318 -----------------------------------------------------------
Regarding the code, everything seems fine. Now the real question is about the shortcuts. Are they really good? Logical? I'm not the one to judge on this. But a Shift+E for instance might have bad repercussions (if you type Editors in the search field, what happens? Is the slot triggered?) If Mamarok says it's ok, then ship it. - Olivier Churlaud On sep. 6, 2015, 7:30 après-midi, Aditya Dev Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124773/ > ----------------------------------------------------------- > > (Updated sep. 6, 2015, 7:30 après-midi) > > > Review request for Amarok, Myriam Schweingruber and Bart Cerneels. > > > Bugs: 300979 > https://bugs.kde.org/show_bug.cgi?id=300979 > > > Repository: amarok > > > Description > ------- > > JJ : Bug - 300979 : Patch to add some shortcuts for various actions in > createActions() in MainWindow > > > Diffs > ----- > > src/MainWindow.cpp 22fb8ce > > Diff: https://git.reviewboard.kde.org/r/124773/diff/ > > > Testing > ------- > > Built and tested. > Removed the shortcuts that matched either the Amarok Global Shortcuts or the > Standard Shortcuts of KDE. > > Clear Playlist : CTRL + SHIFT + C ---------------> SLOT(clear() ) > Add Stream : CTRL + SHIFT + J ---------------> SLOT(slotAddStream() ) > Export Playlits : CTRL + SHIFT + E ---------------> SLOT(exportPlaylist() ) > Bookmarks Manager : CTRL + I ---------------> > SLOT(slotShowBookmarkManager() ) > Equalizer : SHIFT + E ---------------> SLOT(slotShowEqualizer() ) > Cover Manager : CTRL + ALT + C ---------------> > SLOT(slotShowCoverManager() ) > Synchronize Statistics : SHIFT + S ---------------> SLOT(synchronize() ) > > Bookmark Media Sources View : SHIFT + B ----------> > SLOT(bookmarkCurrentBrowserView() ) > Bookmark Playlist Setup : ALT + B ---------------> > bookmarkCurrentPlaylistView() ) > Bookmark Context Applets : CTRL + SHIFT + B ------> > bookmarkCurrentContextView() ) > Disable Dynamic Playlist : ALT + SHIFT + D -------> connected inside dynamic > playlist category > > > About Amarok : ALT + F10 -----------------> SLOT(showAbout()) > Diagnostics : ALT + F8 -----------------> > SLOT(slotShowDiagnosticsDialog()) > Report bug : ALT + F9 -----------------> SLOT(showReportBug()) > > > Thanks, > > Aditya Dev Sharma > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
