----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125126/ -----------------------------------------------------------
(Updated sep. 12, 2015, 2:05 après-midi) Review request for Amarok. Changes ------- Work more, and reduce segfaults Repository: amarok Description (updated) ------- Port of main.cpp and App It compiles 100%, and there is a segmentation fault after the end of the App::continueInit(). I'm not able to trace it further. Please help me to port well the main + App class so that the play, pause (and so one) commands are well read and to deal correctly with the unique/multiple instance. Diffs (updated) ----- src/App.h 2089981 src/scripting/scriptmanager/ScriptManager.cpp bb62be1 src/scanner/AbstractDirectoryWatcher.cpp 168c68a src/org.kde.amarok.desktop PRE-CREATION src/main.cpp 385e047 src/core/support/Components.cpp 9f97eb6 src/configdialog/dialogs/ScriptsConfig.cpp bbec667 src/amarok.desktop 433c757 src/browsers/filebrowser/FileBrowser.cpp 3d40d9b src/TrayIcon.cpp be25497 src/PluginManager.cpp a9a1c47 src/CMakeLists.txt afeef4a src/MainWindow.cpp d3bbc0b src/App.cpp 6028bc8 Diff: https://git.reviewboard.kde.org/r/125126/diff/ Testing (updated) ------- It compiles 100%, and there is a segmentation fault after the end of the App::continueInit(). I'm not able to trace it further. Thanks, Olivier Churlaud
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
