----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125059/ -----------------------------------------------------------
Review request for Amarok. Repository: amarok Description ------- Fix for Amarok's kf5 branch failing to build. Right now it throws the following error: CMakeFiles/amarok_storage-mysqlserverstorage.dir/MySqlServerStorageFactory.cpp.o: In function `factory::factory()': /home/somsubhra/kde/src/amarok/src/core-impl/storage/sql/mysqlserverstorage/MySqlServerStorageFactory.cpp:23: undefined reference to `vtable for factory' CMakeFiles/amarok_storage-mysqlserverstorage.dir/MySqlServerStorageFactory.cpp.o: In function `factory::~factory()': /home/somsubhra/kde/src/amarok/src/core-impl/storage/sql/mysqlserverstorage/MySqlServerStorageFactory.cpp:23: undefined reference to `vtable for factory' collect2: error: ld returned 1 exit status So added the necessary meta object compiler generated file. Diffs ----- src/core-impl/storage/sql/mysqlserverstorage/MySqlServerStorageFactory.cpp dd86d0d Diff: https://git.reviewboard.kde.org/r/125059/diff/ Testing ------- Amarok builds successfully. Thanks, Somsubhra Bairi
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
