Le 11/08/2015 07:00, Aroonav Mishra a écrit :
Hello Olivier,
Hi
I tried getting in touch with you on IRC about this.
On 10 August 2015 at 04:55, Olivier Churlaud <oliv...@churlaud.com
<mailto:oliv...@churlaud.com>> wrote:
@Aroonav: it's specially for you...
tell me what I'm supposed to do with this first work (there are 3
commits in fact).
If it's okay with you I would like to first understand something. I
had disabled the compilation of the files in src/context in
src/CMakeLists.txt in the kf5 branch but I see that you have not
re-enabled their compilation in that cmake file. And if I have
understood correctly then I believe that you are gonna look at the
errors before making the required changes to correct that error. So am
I correct in guessing that you /have/ re-enabled their compilation in
your local repository but you haven't put that change(of enabling the
compilation of src/context) in the commit on the reviewboard.
No. I let everything like you did. The first thing I did is "let see
what compiles" and I compiled the whole project, (with the CMakeList
like you let it). I took the first errors and made everything so that
the compilation go further.
With this I get 19% of the compilation. BUT I have the KPluginInfo
problem, plus a
/usr/include/kcmodule.h:29:25: fatal error: QtGui/QWidget: No
such file or directory
that I don't understand.
It seems that the Qt/KF5 development libraries are not installed(or
not setup) properly on your system. Because that seems to be the first
reason that comes to my mind for the error. It seems to have found the
kdelibs4 version of kcmodule.h and that only seems plausible when the
required kf5 package isn't found. Same goes for the KPluginInfo
problem that you have mentioned on the reviewboard.
The KPluginInfo problem is solved (cf the update) and it was just a
problem of include.
I have the kf5 package since I'm able to compile other parts of the code
based on kf5 (and I'm on archlinux, I compiled several apps without pb).
Cheers
Olivier
Thx
Olivier
Le 10/08/2015 01:13, Olivier Churlaud a écrit :
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124678/
Review request for Amarok.
By Olivier Churlaud.
*Repository: * amarok
Description
It's my first port so I would like to have an external point of view.
Other problem, in the compilation, KPluginInfo is not found:
/home/olivier/Projets/amarok/src/context/tools/amarokpkg.cpp:37:30: fatal
error: Plasma/KPluginInfo: No such file or directory
Diffs
* shared/collectionscanner/ScanningState.cpp (488b5ec)
* src/context/applets/wikipedia/WikipediaApplet.cpp (824e9b7)
* src/context/tools/CMakeLists.txt (1deb7f3)
* src/context/tools/amarokpkg.cpp (2ae1e93)
* src/services/lastfm/meta/LastFmMeta.cpp (46aa8fe)
* tests/TestExpression.h (cfa2a0c)
* tests/TestQStringx.h (8cf14c3)
* tests/TestSmartPointerList.h (72c95aa)
* tests/TestSmartPointerList.cpp (8e9865b)
View Diff <https://git.reviewboard.kde.org/r/124678/diff/>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org <mailto:Amarok-devel@kde.org>
https://mail.kde.org/mailman/listinfo/amarok-devel
Cheers,
Aroonav.
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
