----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121250/#review71398 -----------------------------------------------------------
shared/CMakeLists.txt <https://git.reviewboard.kde.org/r/121250/#comment49846> What is this!!! I just told you in a previous issue not to use such relative includes. Just exclude everything with ".." anywhere in its include line. no "../../foo" Nitul please go through some CMake documentation and understand how (and why) CMake files are written. This is most definitely not supposed to be here. shared/CMakeLists.txt <https://git.reviewboard.kde.org/r/121250/#comment49847> Again. please remove all of these. Does this even look correct to you? `/src/*` files are supposed to be in amaroklib and not in collectionscanner. But you will not know what this means until you go through some CMake documentation. shared/collectionscanner/CueSheet.cpp <https://git.reviewboard.kde.org/r/121250/#comment49848> again whitespace errors. Setup your IDE/Editor. Ask on IRC (in #kde preferably) if you are not sure how to. Did you just remove manually remove whitespaces in the previous review request? :-D Still a lot of newbie mistakes. I cannot do a proper review until you have a successful build. Are you expecting me to fix these CMake errors for you? - Vedant Agarwala On Dec. 4, 2014, 11:52 p.m., Nitul Datt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121250/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 11:52 p.m.) > > > Review request for Amarok and Vedant Agarwala. > > > Repository: amarok > > > Description > ------- > > This is an initial implementation for a CueSheet class in the > CollectionScanner. There are some errors though, which have yet to be sorted > out. > > > Diffs > ----- > > shared/CMakeLists.txt 31ca0f4 > shared/collectionscanner/CueSheet.h PRE-CREATION > shared/collectionscanner/CueSheet.cpp PRE-CREATION > shared/collectionscanner/Directory.h faacce4 > shared/collectionscanner/Directory.cpp a65884b > > Diff: https://git.reviewboard.kde.org/r/121250/diff/ > > > Testing > ------- > > > Thanks, > > Nitul Datt > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
