On Sat, Nov 29, 2014 at 6:09 PM, Nitul Datt <nitul1...@gmail.com> wrote:
> > On 29 Nov 2014 05:48, "vedant agarwala" <vedant.k...@gmail.com> wrote: > > > > > > > > On Sat, Nov 29, 2014 at 5:39 AM, Nitul Datt <nitul1...@gmail.com> wrote: > >> > >> Hey Vedant, > >> > >> On 27 Nov 2014 05:50, "vedant agarwala" <vedant.k...@gmail.com> wrote: > >> > >> > > >> > Nitul, > >> > > >> > "undefined reference" errors are caused when the different files are > not linked together properly. > >> > > >> > You obviously have this problem as you have added new files > (CueSheet.h|cpp) but have not made any entry of it in the CMakeLists.txt. > See how the files are added to CMakeLists.txt and do the same for your > CueSheep.cpp > >> > > >> > >> I've looked that up. > >> > >> > There are many more errors in your diff that we can go about later > when I review your code. > >> > > >> > >> Unfortunately my laptop's hard disk has packed up. So I'll be delayed > by a day or two while I get it fixed. I'll be setting up my development > environment on a friend's laptop in the meanwhile. I'd like to sincerely > apologise for the delay. > > > > > > Well its okay. As long as you make it up later on :) > > > > Also, I would suggest you to set up your own machine rather than a > friend's. Fix yours first. Just delete the windows partition :-P > > I'm afraid it isn't so simple. I have an ssd and a traditional hd on my > laptop. The HD isn't being detected. I took it out of the laptop and tried > connecting it to another system using a master slave connector. It wasn't > detected there either. > So I've dropped off my system at the service center and I'll be getting it > back on Tuesday. > > In the meanwhile I've arranged a friend's old netbook on which I've set up > Git and got the source. I'll try and get the build system running on it as > well. If you could review the earlier code I sent you while I do that, it > would be great. > I will review the code after it builds successfully. Right now I can only tell you to fix the whitespace errors. And, setting up git is only half the story, most importantly you need all the dependencies to build amarok. > On an unrelated note, I don't have Windows on my laptop. I've been > running only Linux on it for about 2 years now. :-p > Haha. That is good to hear. Regards, Vedant. > > You can boot from a pen drive and back up your data and create new > partitions > >> > >> > Regards, > >> > Vedant. > >> > > >> > > >> > On Thu, Nov 27, 2014 at 5:43 AM, vedant agarwala < > vedant.k...@gmail.com> wrote: > >> >> > >> >> > >> >> > >> >> On Thu, Nov 27, 2014 at 12:58 AM, Nitul Datt <nitul1...@gmail.com> > wrote: > >> >>> > >> >>> Hey Vedant, > >> >>> > >> >>> On 11/26/14, vedant agarwala <vedant.k...@gmail.com> wrote: > >> >>> > Hello Nitul, > >> >>> > > >> >>> > Also paste a link to the error using paste.kde.org in the > description. > >> >>> > > >> >>> > >> >>> I have done so. The link is as follows: http://goo.gl/Csp8uW > >> >>> > >> >>> > It is a very large diff to analyze. seems like you have added a > lot of > >> >>> > redundant lines in the form of comments. remove them. You should > have the > >> >>> > old code in git and not need to keep them as comments. > >> >>> > > >> >>> > >> >>> I have removed the appropriate lines and updated my diff. > >> >>> > >> >>> > I will take some time to run the code myself. I can only look at > the code > >> >>> > and see if the error is obvious. > >> >>> > > >> >>> > >> >>> That would be great. > >> >>> > >> >>> > In any case, also provide a link to the personal scratch repo > commit so > >> >>> > that i can directly pull from there and run the code when I can. > >> >>> > > >> >>> > >> >>> I haven't commited the code as of yet as it still isn't working > properly. > >> >> > >> >> > >> >> > >> >> I know it isn't. That is why you will upload to *your personal* > repository. > >> >> > >> >>> > >> >>> > >> >>> > Regards, > >> >>> > Vedant. > >> >>> > > >> >>> > On Wed, Nov 26, 2014 at 2:01 AM, Nitul Datt <nitul1...@gmail.com> > wrote: > >> >>> > > >> >>> >> Hey! > >> >>> >> > >> >>> >> I've put up an initial patch on reviewboard. It's not completely > error > >> >>> >> free and I need some help figuring out what's wrong. > >> >>> >> > >> >>> >> -- > >> >>> >> Regards, > >> >>> >> Nitul Datt > >> >>> >> > >> >>> > > >> >>> > >> >>> -- > >> >>> Regards, > >> >>> Nitul Datt > >> >> > >> >> > >> > > >> > >> -- > >> Regards, > >> Nitul Datt > > > > > > -- > Regards, > Nitul Datt >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
