-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113346/
-----------------------------------------------------------
(Updated Oct. 19, 2013, 8:52 p.m.)
Review request for Amarok.
Bugs: 317902
https://bugs.kde.org/show_bug.cgi?id=317902
Repository: amarok
Description
-------
When ffmpeg is not available, the transcoding dialog will not be skipped;
rather it will add a note for the user to install an encoder.
Diffs (updated)
-----
src/core/collections/CollectionLocation.cpp 2385570
src/transcoding/TranscodingAssistantDialog.cpp 17fc250
src/transcoding/TranscodingAssistantDialog.ui 0ad83b2
Diff: http://git.reviewboard.kde.org/r/113346/diff/
Testing
-------
* Compiles
* Works as expected
File Attachments (updated)
----------------
Transcoding dialog with the note.
http://git.reviewboard.kde.org/media/uploaded/files/2013/10/19/424771d9-a0ae-4eaf-824b-4b6bd2b840ee__snapshot1.png
Transcoding dialog UI Revision
http://git.reviewboard.kde.org/media/uploaded/files/2013/10/19/9a2c58c1-5597-40a5-951b-3783226156e4__snapshotv2.png
Thanks,
Jai Luthra
_______________________________________________
Amarok-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/amarok-devel
