> On Sept. 20, 2013, 11:33 a.m., Matěj Laitl wrote: > > src/dbus/mpris2/org.kde.amarok.Mpris2Extensions.Player.xml, lines 21-23 > > <http://git.reviewboard.kde.org/r/112802/diff/2/?file=190470#file190470line21> > > > > Hmm, I must say I don't like having a rating property for a "player" > > object, because it doesn't logically belong there. It logically belongs to > > a "track". > > > > For reading purposes, the only reasonable place is > > MediaPlayer2.TrackList.GetTracksMetadata, and we *already* fill in > > xesam:userRating, so please let's don't add unnecessary redundancy (yet > > another undocumented ad-hoc method). > > > > For writing let's wait for the outcome of the discussion on the MPRIS > > list.
The MPRIS list seems quite dead to me, but let's wait a bit... I'll take care of the other issues as soon as we agree on how to write rating. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112802/#review40381 ----------------------------------------------------------- On Sept. 18, 2013, 7:34 p.m., Alex Busenius wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112802/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2013, 7:34 p.m.) > > > Review request for Amarok and Alex Merry. > > > Description > ------- > > The D-Bus interface is currently missing convenient method for reading and > setting user rating (the stars). The proposed patch adds an Mpris2 extension > to /org/mpris/MediaPlayer2 for that: > > property readwrite int org.kde.amarok.Mpris2Extensions.Player.Rating > > > Diffs > ----- > > src/dbus/mpris2/MediaPlayer2AmarokExtensions.h 964c7b8 > src/dbus/mpris2/MediaPlayer2AmarokExtensions.cpp ba8b54e > src/dbus/mpris2/org.kde.amarok.Mpris2Extensions.Player.xml 3397df4 > > Diff: http://git.reviewboard.kde.org/r/112802/diff/ > > > Testing > ------- > > > Thanks, > > Alex Busenius > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
