> On Sept. 12, 2013, 9:04 p.m., Matěj Laitl wrote: > > Ship it! (and no, I think HTTPS should be the default, let's heat those NSA > > supercomputers a bit. > > Frank Meerkoetter wrote: > I have to recall this patch. I noticed that there is still some HTTP > traffic. I will look into it tomorrow.
This was due to a local problem i had introduced while updating after the review. After backing that out the patch was fine. I have only re-opened this review for completeness and to document this. I will push the fix to master now - Frank ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/#review39923 ----------------------------------------------------------- On Sept. 13, 2013, 8:32 p.m., Frank Meerkoetter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112706/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2013, 8:32 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Allow to use wikipedia over SSL. Make encrypted connections the default. Add > an option to fall back to plain HTTP. > > > This addresses bug 322249. > https://bugs.kde.org/show_bug.cgi?id=322249 > > > Diffs > ----- > > src/context/applets/wikipedia/WikipediaApplet.cpp 507db96 > src/context/applets/wikipedia/WikipediaApplet_p.h c52a0bf > src/context/applets/wikipedia/wikipediaGeneralSettings.ui a615dee > src/context/engines/wikipedia/WikipediaEngine.cpp f22e443 > > Diff: http://git.reviewboard.kde.org/r/112706/diff/ > > > Testing > ------- > > Switched several times between HTTP and HTTPS. Switched between the normal > and the mobile version. > Checked the traffic with wireshark. Verified that this setting is actually > persisted. > > > Thanks, > > Frank Meerkoetter > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
