----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112266/#review38527 -----------------------------------------------------------
Thanks for the patch. Please answer some remarks below. shared/tag_helpers/APETagHelper.cpp <http://git.reviewboard.kde.org/r/112266/#comment28492> Hmm, is there a specification somewhere that says what the proper identifiers are? I fear of backwards compatibility, perhaps there are files out there that use the title-cased identifiers? shared/tag_helpers/APETagHelper.cpp <http://git.reviewboard.kde.org/r/112266/#comment28493> Does the spec say what format does disc number has? Perhaps we should be able to read both formats? - Matěj Laitl On Aug. 25, 2013, 1:17 p.m., Bruno Léon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112266/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2013, 1:17 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Fix reading of Album Artist and Compilation tag in APE tags. > Add support for reading Disc Number in APE tags. > > > Diffs > ----- > > shared/tag_helpers/APETagHelper.cpp c628694 > > Diff: http://git.reviewboard.kde.org/r/112266/diff/ > > > Testing > ------- > > Tested with Musepack files (that do use APE tags) > > > Thanks, > > Bruno Léon > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
