----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112263/ -----------------------------------------------------------
Review request for Amarok. Description ------- More janitor work. EBN: Check for foreach loop issues. Fixing a number of issues from http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html [...] 13. Check for foreach loop issues [foreach]... [...] Calling values() isn't necessary here. foreach will iterate over the values by default. Diffs ----- src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 4d2352d src/context/applets/upcomingevents/UpcomingEventsStack.cpp dd9e149 src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp f19ff4d src/core-impl/collections/support/MemoryMatcher.cpp 6e94647 src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 793358b Diff: http://git.reviewboard.kde.org/r/112263/diff/ Testing ------- Unit tests still pass. Thanks, Frank Meerkoetter
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
