----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112199/#review38515 -----------------------------------------------------------
This review has been submitted with commit 01a4ce741420f76c7945063e58a2ccd5acdd5209 by Mark Kretschmann on behalf of Frank Meerkoetter to branch master. - Commit Hook On Aug. 22, 2013, 7:04 p.m., Frank Meerkoetter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112199/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 7:04 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Fixing a number of issues from > http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html > [...] > 13. Check for foreach loop issues [foreach]... > [...] > > Prefer a const reference over a copy. This patch is only a first batch - > fixing the simple cases. > > > This addresses bug 313504. > https://bugs.kde.org/show_bug.cgi?id=313504 > > > Diffs > ----- > > shared/TagsFromFileNameGuesser.cpp 0ae8dbd > src/EngineController.cpp 99adb53 > src/OpmlParser.cpp e47e103 > src/configdialog/dialogs/MetadataConfig.cpp 5701d77 > src/context/applets/labels/LabelsApplet.cpp f5bc55d > src/core-impl/collections/daap/DaapCollection.cpp 20e7b4f > src/core-impl/collections/daap/daapreader/Reader.cpp a80922c > src/core-impl/collections/db/MountPointManager.cpp dc74896 > src/core-impl/collections/db/sql/SqlCollectionLocation.cpp c11a6bd > src/core-impl/collections/ipodcollection/IpodCollectionFactory.cpp 7ecdcfa > src/core-impl/collections/ipodcollection/IpodPlaylistProvider.cpp ff9e4ad > src/core-impl/collections/ipodcollection/jobs/IpodParseTracksJob.cpp > b699b6e > src/core-impl/collections/ipodcollection/support/IphoneMountPoint.cpp > 2926e77 > src/core-impl/collections/playdarcollection/support/Query.cpp 29619a9 > src/core-impl/collections/support/CollectionManager.cpp db5c984 > src/core-impl/collections/umscollection/podcasts/UmsPodcastProvider.cpp > 7579ba2 > src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp 6467964 > src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp 80ea8de > src/core-impl/collections/upnpcollection/UpnpQuery.cpp e945bfd > src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp 67e153f > src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.cpp c77f920 > src/core-impl/meta/cue/CueFileSupport.cpp 77d27e6 > src/core/transcoding/TranscodingConfiguration.cpp dbcd0b3 > src/core/transcoding/formats/TranscodingAacFormat.cpp 2b0a02c > src/core/transcoding/formats/TranscodingFlacFormat.cpp fd8a832 > src/core/transcoding/formats/TranscodingMp3Format.cpp 83d0e2f > src/core/transcoding/formats/TranscodingOpusFormat.cpp 3ee991b > src/core/transcoding/formats/TranscodingVorbisFormat.cpp 8c32d69 > src/core/transcoding/formats/TranscodingWmaFormat.cpp d7646d2 > src/covermanager/CoverCache.cpp 14a4646 > src/databaseimporter/amarok14/FastForwardWorker.cpp 113141d > src/dialogs/CollectionSetup.cpp 0672421 > src/dialogs/OrganizeCollectionDialog.cpp a29e626 > src/dialogs/TagDialog.cpp 3c07fd1 > src/network/NetworkAccessViewer.cpp f5a91dd > src/playlist/layouts/PlaylistLayoutEditDialog.cpp 4211010 > src/playlistmanager/file/KConfigSyncRelStore.cpp b8dd4c4 > src/services/lastfm/ScrobblerAdapter.cpp 3c81546 > src/services/lastfm/SynchronizationAdapter.cpp ae4b820 > src/services/opmldirectory/OpmlDirectoryView.cpp feba375 > src/statsyncing/Config.cpp 40dc79d > src/transcoding/TranscodingOptionsStackedWidget.cpp 26128d5 > src/widgets/FilenameLayoutWidget.cpp aee4175 > utilities/collectionscanner/CollectionScanner.cpp dd4ae37 > > Diff: http://git.reviewboard.kde.org/r/112199/diff/ > > > Testing > ------- > > All unit tests pass. > > > Thanks, > > Frank Meerkoetter > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
