-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112139/
-----------------------------------------------------------
Review request for Amarok.
Description
-------
style: prefer QString.clear over a null-assign
See:
http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html
[...]
Check for assignments to QString::null [nullstrassign]...OOPS! 6 issues
found!
src/services/amazon/AmazonStore.cpp: line# 116 (1)
src/dialogs/TagDialog.cpp: line# 835 (1)
src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp: line# 261 (1)
src/core-impl/collections/db/sql/SqlMeta.cpp: line# 904,1737,1886 (3)
[...]
This addresses bug 313504.
https://bugs.kde.org/show_bug.cgi?id=313504
Diffs
-----
src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 903f206
src/core-impl/collections/db/sql/SqlMeta.cpp c91b760
src/dialogs/TagDialog.cpp f67b99d
src/services/amazon/AmazonStore.cpp d4eb628
Diff: http://git.reviewboard.kde.org/r/112139/diff/
Testing
-------
Thanks,
Frank Meerkoetter
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
