----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110036/ -----------------------------------------------------------
(Updated April 18, 2013, 7:50 a.m.) Review request for Amarok. Description ------- A new, unambitious attempt at adding equalizer functions to the scripting interface. Adds to EngineController the functions: * QString eqPreset() * void eqApplyPreset(QString name) And the signal: eqPresetApplied(QString name) Adds to AmarokEngineScript the same functions set up as a property. Diffs (updated) ----- src/scriptengine/AmarokEngineScript.cpp 4d52bbe src/scriptengine/AmarokEngineScript.h f1cdb8c src/EngineController.cpp 28fb256 src/EngineController.h 5de4beb Diff: http://git.reviewboard.kde.org/r/110036/diff/ Testing ------- Quick check using the script console that presets can be changed. The preset does get applied but it won't show in the EqualizerDialog. Possible other bugs. Thanks, Ryan McCoskrie
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
