----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100321/#review27100 -----------------------------------------------------------
Ralf, do you want to incorporate some of the suggestions into the new organize collection dialog? I agree that pressing "Update preset" should be permanent even if you hit the Cancel button afterwards. Additionally, there are some minor bugs with the new dialog (bad place to mention them here, but this is minor): * switching between advanced and basic breaks curly braces in the advanced preset and and also the preview (I use the curly braces a lot) * the "Update button" doesn't get enabled if you edit a preset in advanced mode - Matěj Laitl On Jan. 8, 2011, 12:12 p.m., Philipp Schmidt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100321/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2011, 12:12 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Fixes two errors: > > First: Presets are being saved explicitely, meaning they should persist even > when the Dialog is aborted/canceled. > Second: The state of the Current Collection Directory is saved regardless of > whether the Dialog was accepted or canceled. IMO it should only be saved like > all other values when it is accepted. > > > Diffs > ----- > > ChangeLog 3c337d1 > src/dialogs/OrganizeCollectionDialog.cpp b7d7850 > > Diff: http://git.reviewboard.kde.org/r/100321/diff/ > > > Testing > ------- > > > Thanks, > > Philipp Schmidt > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
