----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107161/#review21472 -----------------------------------------------------------
src/core-impl/collections/nepomukcollection/NepomukCollection.cpp <http://git.reviewboard.kde.org/r/107161/#comment16698> I'm confused. You aren't really constructing anything. src/core-impl/collections/nepomukcollection/NepomukCollection.cpp <http://git.reviewboard.kde.org/r/107161/#comment16696> What's the need for this fileRes? You could just directly do res( url ). src/core-impl/collections/nepomukcollection/NepomukCollection.cpp <http://git.reviewboard.kde.org/r/107161/#comment16697> In the Nepomuk code I generally prefer a 'using namespace Nepomuk::Vocabulary' at the top. This however is not Nepomuk code, so it's your choice :) - Vishesh Handa On Oct. 31, 2012, 7:35 p.m., Phalgun Guduthur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107161/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2012, 7:35 p.m.) > > > Review request for Amarok, Edward Hades Toroshchin and Vishesh Handa. > > > Description > ------- > > First footstep in completing the Nepomuk Collection. > > The non virtual methods belonging to TrackProvider implemented. > Repeated documentation to help vHanda understand the purpose of those > functions. > > > Diffs > ----- > > src/core-impl/collections/nepomukcollection/NepomukCollection.h d920ff6 > src/core-impl/collections/nepomukcollection/NepomukCollection.cpp 0593697 > > Diff: http://git.reviewboard.kde.org/r/107161/diff/ > > > Testing > ------- > > Minimal. > > > Thanks, > > Phalgun Guduthur > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
