-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106175/#review17998
-----------------------------------------------------------

Ship it!


Yes, indeed, thanks!

@other Amarok devs: I'm time-constrained now, please commit this with ChangeLog 
entry and appropriate BUG: and FIXED-IN: keywords.

- Matěj Laitl


On Aug. 25, 2012, 12:51 p.m., Milan Izai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106175/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2012, 12:51 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> After finishing the last track in "Repeat Playlist" mode, Amarok scans 
> playlist from the beginning in order to determine the next track to play. 
> However the last track played is not included in this scan. This leads to a 
> strange behavior when playlist contains only 1 track. In this case Amarok 
> just stops playback instead of repeating the only track in playlist. The 
> bugfix is trivial: just include the last track when scanning playlist.
> 
> 
> This addresses bug 290955.
>     https://bugs.kde.org/show_bug.cgi?id=290955
> 
> 
> Diffs
> -----
> 
>   src/playlist/navigators/StandardTrackNavigator.cpp 
> f9af2ef8687bc691bcce419f4773d6038db6c9af 
> 
> Diff: http://git.reviewboard.kde.org/r/106175/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milan Izai
> 
>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Reply via email to