----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105823/#review16792 -----------------------------------------------------------
Ship it! Looks good, push then master is opened after 2.6. Don't forget ChangeLog entry and please search bugzilla for any possibly closed bugs. src/core-impl/playlists/providers/user/UserPlaylistProvider.cpp <http://git.reviewboard.kde.org/r/105823/#comment13081> Nitpicky: too much newlines, we don't usually use more than one. src/core-impl/playlists/providers/user/UserPlaylistProvider.cpp <http://git.reviewboard.kde.org/r/105823/#comment13080> Does setCustomWidget() take ownership of the pointer? Probably yes. - Matěj Laitl On Aug. 2, 2012, 12:13 p.m., Ralf Engels wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105823/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2012, 12:13 p.m.) > > > Review request for Amarok. > > > Description > ------- > > This patch will enable to export a playlist directly with right click. > No longer do I need to add a playlist to the play queue and then select > export from the menu. > > > Diffs > ----- > > src/core-impl/playlists/providers/user/UserPlaylistProvider.cpp 414abec > > Diff: http://git.reviewboard.kde.org/r/105823/diff/ > > > Testing > ------- > > > Thanks, > > Ralf Engels > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
