----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103704/ -----------------------------------------------------------
Review request for Amarok. Description ------- Remove setUidUrl function from EditCapability. The only reference to that was in the Edit dialog, but the code was unreachable. Also remove setUidUrl from different classes where it was not used. Conceptually it should not be possible for the unique id of a track to change as we are using it as identifier. Different uid means different track. 50 code lines less. Diffs ----- src/core-impl/capabilities/timecode/TimecodeEditCapability.h 9c6d553 src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp baeed46 src/core-impl/collections/mediadevicecollection/MediaDeviceEditCapability.h 7acfb2b src/core-impl/collections/mediadevicecollection/MediaDeviceEditCapability.cpp 992c8a5 src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h b44c8eb src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp f4d9af4 src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp 05411a3 src/core-impl/meta/file/File.h 9e02547 src/core-impl/meta/file/File.cpp 9832c6f src/core-impl/meta/proxy/MetaProxy.h 1893f4b src/core-impl/meta/proxy/MetaProxy.cpp 3c33624 src/core/capabilities/EditCapability.h 8064e6a src/dialogs/TagDialog.cpp a2ee45d Diff: http://git.reviewboard.kde.org/r/103704/diff/diff Testing ------- All test cases executed. Compiled and running. Thanks, Ralf Engels
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
