----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100725/#review3345 -----------------------------------------------------------
Ship it! The patch looks good in principle. I am wondering, is there a bug entry that this patch fixes? - Ralf On Feb. 23, 2011, 7:34 p.m., Peter C. Ndikuwera wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100725/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2011, 7:34 p.m.) > > > Review request for Amarok. > > > Summary > ------- > > Used MassStorageDeviceHandler as a template, then changed the following: > > SQLStorage - should use StorageAccess instead of StorageVolume. StorageVolume > only sees physical volumes on the local PC. StorageAccess sees all accessible > storage. > > NFS & SMS DeviceHandlers use KMountPoint to find where the disk is mounted. > > > Diffs > ----- > > src/core-impl/collections/db/sql/MountPointManager.cpp ed29f48 > src/core-impl/collections/db/sql/device/CMakeLists.txt 1baaf85 > src/core-impl/collections/db/sql/device/nfs/CMakeLists.txt 6807dd6 > src/core-impl/collections/db/sql/device/nfs/NfsDeviceHandler.h 21c1894 > src/core-impl/collections/db/sql/device/nfs/NfsDeviceHandler.cpp 91af710 > src/core-impl/collections/db/sql/device/smb/CMakeLists.txt fc27d5a > src/core-impl/collections/db/sql/device/smb/SmbDeviceHandler.h c74c840 > src/core-impl/collections/db/sql/device/smb/SmbDeviceHandler.cpp 2f19e28 > > Diff: http://git.reviewboard.kde.org/r/100725/diff > > > Testing > ------- > > Mounted nfs and samba/cifs shares and did full rescans. Then unmounted them > one by one. Works perfectly. > > Haven't tested what happens if you mount a share that's _not_ in /etc/fstab. > > > Thanks, > > Peter C. > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
