-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100928/
-----------------------------------------------------------
Review request for Amarok.
Summary
-------
Fix 260352 where removing tracks from the playlist after applying a filter,
does not show the "Warning: tracks have been hidden in the playlist" label.
This fixes it by re-applying the filter on the PrettyListView so that it emits
the found/notFound signals. Since the filter itself hasn't changed, proxy
updates don't happen, so it shouldn't be a performance hit.
Change is minor but submitted for review since it is an unfamiliar piece of
code, and also for educational purposes
This addresses bug 260352.
https://bugs.kde.org/show_bug.cgi?id=260352
Diffs
-----
src/playlist/view/listview/PrettyListView.h f22a7c8
src/playlist/view/listview/PrettyListView.cpp cd650f6
Diff: http://git.reviewboard.kde.org/r/100928/diff
Testing
-------
Yes, it works fine. It is shown only when all filtered tracks are deleted as
expected.
Thanks,
Nikhil Shantanu
_______________________________________________
Amarok-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/amarok-devel
