On Sun, Jan 08, 2017 at 06:35:39PM +0000, Jose M Calhariz wrote: > I am reviewing the patches used by Debian to build amanda 3.3.9 and > updating them for amanda 3.4.1. I think some of them are not specific > to Debian. My plan is to present the patches here so they can be > reviewed for adoption or not. > > The first batch are about small English mistakes in documentation that > lintian complains. > > In attach there is 3 patches. > > Kind regards > Jose M Calhariz > > No comment on first, editorial suggestion on second, and comment on third. > > -- > -- > Erro de usuário: Troque o usuário e pressione qualquer tecla para continuar.
> Description: Fix miss spelling that are pointed by lintian. > Author: Jose M Calhariz <[email protected]> > > Index: amanda-3.4.1/man/amanda-auth.7 [snip] > =================================================================== > --- amanda-3.4.1.orig/man/amanda-changers.7 2017-01-08 17:17:49.620890682 > +0000 > +++ amanda-3.4.1/man/amanda-changers.7 2017-01-08 17:17:49.620890682 > +0000 > @@ -132,7 +132,7 @@ define changer aggregate { > tpchanger "aggregate" > .fi > .PP > -This changer driver allow to use two or more changers or standalone drive in > sequence\&. > +This changer driver allow one to use two or more changers or standalone > drive in sequence\&. This changer driver allows the use of two or more changers or standalone drives in sequence\&. ^^^^^^^^^^^^ ^^^ > .SS "Properties" > .PP > LOCK\-TIMEOUT > Index: amanda-3.4.1/man/amanda-devices.7 > =================================================================== > --- amanda-3.4.1.orig/man/amanda-devices.7 2017-01-08 17:17:49.620890682 > +0000 > +++ amanda-3.4.1/man/amanda-devices.7 2017-01-08 17:17:49.620890682 +0000 I have amanda 3.3.3 and 3.3.9 systems in use. The text is very different and conflicting (see below). Assuming the newer is correct my editorial suggestions are: > @@ -778,7 +778,7 @@ INDIRECT > .RS 4 > > (read\-write) The default in "yes"\&. You can set it to "no" if the ndmp > server is Set INDIRECT to "no" if the ndmp server > -allow to set a window length to 0\&. > +allow one to set a window length to 0\&. can be set to a window length of 0. > .RE > .PP > NDMP_AUTH Here is the text of the two amanda versions: 3.3.3 (read-write) Set to "yes" if the ndmp server doesn't allow to set a window length to 0. The default is "no". 3.3.9 (read-write) The default in "yes". You can set it to "no" if the ndmp server allow to set a window length to 0. Obviously the defaults are opposite and should be confirmed. But I wonder about the semantics of the INDIRECT parameter. As described, YES means CAN NOT set to ZERO NO means CAN set to ZERO That may be correct, just seems unusual semantics. Jon -- Jon H. LaBadie [email protected] 11226 South Shore Rd. (703) 787-0688 (H) Reston, VA 20190 (703) 935-6720 (C)
