Jose,
The patch is good and I committed it.
Thanks for reporting the issue.
Jean-Louis
On 03/01/17 02:51 PM, Jose M Calhariz wrote:
> A user of amanda on Debian have sent me a patch to fix a problem in
> amanda 3.3.8. I do not know enough perl to validate the patch. But a
> quick look to the file, seams to not changed much between 3.3.8 and
> amanda 3.4.1.
>
> Can someone review the patch and give the opnion if it fix a problem
> or not?
>
> The patch for amanda 3.3.8 is:
>
> --- /tmp/robot.pm 2016-12-27 09:41:57.285488949 -0700
> +++ /usr/lib/amanda/perl/Amanda/Changer/robot.pm 2016-12-27
> 09:41:34.045222046 -0700
> @@ -2359,6 +2359,7 @@
> use Amanda::Debug qw( debug warning );
> use Amanda::MainLoop qw( :GIOCondition synchronized make_cb define_steps
> step );
> use Amanda::Device qw( :constants );
> +use Carp;
>
> sub new {
> my $class = shift;
>
>
> The URL to the bugreport is:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=849481
>
> Kind regards
> Jose M Calhariz
>
>
>
>
Disclaimer
The information contained in this communication from the sender is
confidential. It is intended solely for use by the recipient and others
authorized to receive it. If you are not the recipient, you are hereby notified
that any disclosure, copying, distribution or taking action in relation of the
contents of this information is strictly prohibited and may be unlawful.
This email has been scanned for viruses and malware, and may have been
automatically archived by Mimecast Ltd, an innovator in Software as a Service
(SaaS) for business. Providing a safer and more useful place for your human
generated data. Specializing in; Security, archiving and compliance. To find
out more visit the Mimecast website.
