On Fri, Dec 15, 2023 at 12:22 PM, Marco Tiloca <marco.til...@ri.se> wrote:
> Hello Warren, > > Thanks a lot for your review! Please find in line below our detailed > replies to your comments. > > A Github PR where we have addressed your comments is available at [PR]. > Awesome, thank you. All looks good to me! W > Unless any concern is raised, we plan to soon merge this PR (and the other > ones related to other received reviews), and to submit the result as > version -18 of the document. > > Thanks, > /Marco > > [PR] https://github.com/ace-wg/ace-key-groupcomm/pull/165 > > On 2023-11-29 20:54, Warren Kumari via Datatracker wrote: > > Warren Kumari has entered the following ballot position for > draft-ietf-ace-key-groupcomm-17: No Objection > > When responding, please keep the subject line intact and reply to all > email addresses included in the To and CC lines. (Feel free to cut this > introductory paragraph, however.) > > > Please refer to > https://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Fabout%2Fgroups%2Fiesg%2Fstatements%2Fhandling-ballot-positions%2F&data=05%7C01%7Cmarco.tiloca%40ri.se%7C4c1aa823359841f0231308dbf114ffad%7C5a9809cf0bcb413a838a09ecc40cc9e8%7C0%7C0%7C638368844728564431%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=glipPpF8qR4XdpmB2pNm5hBOYLOPxph4lOpOlbMHdV0%3D&reserved=0 > for more information about how to handle DISCUSS and COMMENT positions. > > > The document, along with other ballot positions, can be found > here:https://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracker.ietf.org%2Fdoc%2Fdraft-ietf-ace-key-groupcomm%2F&data=05%7C01%7Cmarco.tiloca%40ri.se%7C4c1aa823359841f0231308dbf114ffad%7C5a9809cf0bcb413a838a09ecc40cc9e8%7C0%7C0%7C638368844728570855%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xAxbw8qHY2nryW00RMHAW7ZpYqntdyEE96nqN%2FKBVWw%3D&reserved=0 > > > > ---------------------------------------------------------------------- > COMMENT: > ---------------------------------------------------------------------- > > Thank you for writing this document - I found it both useful, and an easy > read. > > I do have a nit / readability suggestion: > > "New keying material is generated and distributed to the group upon > membership changes (rekeying), if the application requires backward > security (i.e., new group members must be prevented from accessing > communications in the group prior to their joining) and forward > security (i.e., former group members must be prevented from > accessing communications in the group after their leaving)." > > I found this wording confusing - I think that it is the comma after "upon > membership changes (rekeying)". This initially sounds like "new keys are > generated on every membership change. If the application requires backward > security then [something else / something additional". I *think* that just > dropping the comma fixes it... > > > ==>MT > > We have rephrased the paragraph as follows. > > OLD > > New keying material is generated and distributed to the group upon > membership changes (rekeying), if the application requires backward > security (i.e., new group members must be prevented from accessing > communications in the group prior to their joining) and forward security > (i.e., former group members must be prevented from accessing communications > in the group after their leaving). > > NEW > > New keying material is intended to be generated and distributed to the > group upon membership changes (rekeying). If the application requires > backward security (i.e., new group members must be prevented from accessing > communications in the group prior to their joining), then a rekeying has to > occur every time new members join the group. If the application requires > forward security (i.e., former group members must be prevented from > accessing communications in the group after their leaving), then a rekeying > has to occur every time current members leave the group or are evicted from > the group. > > <== > > You also have a typo: "It is REQUIRED of application profiles of this > specificaton to" - specification. > > > ==>MT > > Yes, fixed in a previous editorial PR at https://github.com/ace-wg/ > ace-key-groupcomm/pull/156/files > > <== > > > > -- > Marco Tiloca > Ph.D., Senior Researcher > > Phone: +46 (0)70 60 46 501 > > RISE Research Institutes of Sweden AB > Box 1263 > 164 29 Kista (Sweden) > > Division: Digital Systems > Department: Computer Science > Unit: Cybersecurity > https://www.ri.se > >
_______________________________________________ Ace mailing list Ace@ietf.org https://www.ietf.org/mailman/listinfo/ace
