> I've attached the two patch sets, I make no claim to being a great
> coder, the focus was to make the changes (a) as clear as possible, (b)
> as unintrusive as possible.

-       if(port == nil){
-               port = "ssh";
-               s = strchr(host, ':');
-               if(s != nil){
-                       *s = '\0';
-                       port = s+1;
-               }
-       }

this breaks for ipv6 addresses. i'd suggest you at least check for ] first
and then look for the colon. example: "[::1]:22".

then the big question is what should be put in the thumb file to identify
the host, if you start messing with the network addresses. there can be
different ssh servers per port. for example: gerrit.

--
cinap

------------------------------------------
9fans: 9fans
Permalink: 
https://9fans.topicbox.com/groups/9fans/T0cc6edbc13d3e92c-M7f81cd380693f5bdc8956d42
Delivery options: https://9fans.topicbox.com/groups/9fans/subscription

Reply via email to