I think your code is wrong. If the NUL byte is present, it doesn't do anything, however if it is not there, strlen will read more than it should, and possibly try to read some invalid address. In case info.host is a fixe size array, a simple info.host[sizeof info.host - 1] = 0; would do.
Am 05.06.2013 15:13, schrieb Don Bailey: > The first opportunity to write a nil byte should always be taken. Using > sizeof only means that in corner cases memory disclosure may occur between > where the nil should be and the end of the array. While this isn't a security > critical app, it is still good coding practice. > > x = strlen(info.host) < sizeof info.host ? strlen() : sizeof ; > info.host[x] = 0; > > D >
